Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20606461
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -269,6 +283,21 @@ public void open(FileInputSplit split) throws
IOException {
protected boolean parseRecord(Object[] holders, byte[] bytes, int
offset, int numBytes) throws ParseException {
+ if (commentPrefix != null) {
+ //check record for comments
+ String s = new String(bytes, offset, numBytes).trim();
--- End diff --
We try to avoid object instantiations as much as possible and parse the
data as a `byte[]`. This effort is voided if we make the line a String for the
purpose of comment checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
