[
https://issues.apache.org/jira/browse/FLINK-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220737#comment-14220737
]
ASF GitHub Bot commented on FLINK-1208:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-63948901
Looks quite good. A few comments in line.
I'm not sure if we should do the comment check in the DelimitedIF or in the
CSVIF. Doing it in the DelimitedIF, it means overhead for all other IFs that
extend it.
> Skip comment lines in CSV input format. Allow user to specify comment
> character.
> --------------------------------------------------------------------------------
>
> Key: FLINK-1208
> URL: https://issues.apache.org/jira/browse/FLINK-1208
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 0.8-incubating
> Reporter: Aljoscha Krettek
> Assignee: Felix Neutatz
> Priority: Minor
> Labels: starter
>
> The current skipFirstLine is limited. Skipping arbitrary lines that start
> with a certain character would be much more flexible while still easy to
> implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)