[
https://issues.apache.org/jira/browse/FLINK-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222259#comment-14222259
]
ASF GitHub Bot commented on FLINK-1208:
---------------------------------------
Github user FelixNeutatz commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-64100176
So I would need to iterate over the content of
DelimitedInputFormat.nextRecord():
```java
if (readLine()) {
return readRecord(record, this.currBuffer, this.currOffset,
this.currLen);
} else {
this.end = true;
return null;
}
```
The problem is, in CsvInputFormat I have no access to this.currBuffer,
this.currOffset, this.currLen. Therefore I see only two alternatives:
1) I copy the functionality of readLine() to CsvInputFormat
2) change access of the private variables this.currBuffer, this.currOffset,
this.currLen in DelimitedInputFormat to protected or add corresponding
getFunctions ...
What is the better solution in your opinion
> Skip comment lines in CSV input format. Allow user to specify comment
> character.
> --------------------------------------------------------------------------------
>
> Key: FLINK-1208
> URL: https://issues.apache.org/jira/browse/FLINK-1208
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 0.8-incubating
> Reporter: Aljoscha Krettek
> Assignee: Felix Neutatz
> Priority: Minor
> Labels: starter
>
> The current skipFirstLine is limited. Skipping arbitrary lines that start
> with a certain character would be much more flexible while still easy to
> implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
