Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-64166021
Why should CsvInputFormat require access to currBuffer, etc?
If configured lenient, `DelimitedInputFormat.nextRecord()` calls
`readLine()` and `readRecord()` until `readRecord()` returns a non-null value
(or `readLine()` is false). This way, `CsvInputFormat.readRecord()` is called
with the correct buffer, offset, and length information. In both cases of
comment and invalid lines, `CsvInputFormat.readRecord()` returns null.
If not configured lenient, DelimitedInputFormat raises an exception if a
null value is returned.
Logging should still happen in CsvInputFormat, because DelimitedIF cannot
distinguish between invalid and comment lines.
Would that work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
