[
https://issues.apache.org/jira/browse/FLINK-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222977#comment-14222977
]
ASF GitHub Bot commented on FLINK-1276:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/227#discussion_r20788933
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/CompactingHashTable.java
---
@@ -718,8 +719,7 @@ private void createPartitions(int numPartitions) {
}
private void clearPartitions() {
- for (int i = 0; i < this.partitions.size(); i++) {
- InMemoryPartition<T> p = this.partitions.get(i);
+ for (InMemoryPartition<T> p : this.partitions) {
--- End diff --
The for-each syntax creates an iterator, while the for loop with indexes
does not.
I think this is not critical here, but in general, I have used the indexed
access in some parts on purpose to avoid iterator creation and circumvent the
danger of a concurrent modification exception.
> Misspelled class name SlotAvalablbilityListener.java
> ----------------------------------------------------
>
> Key: FLINK-1276
> URL: https://issues.apache.org/jira/browse/FLINK-1276
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Affects Versions: 0.8-incubating
> Reporter: Suneel Marthi
> Assignee: Suneel Marthi
> Priority: Trivial
> Fix For: 0.8-incubating
>
>
> 1. Misspelled Class name - 'SlotAvailablblityListener'.
> 2. All methods in MathUtils.java are declared as static final.
> 3. Many other minor fixes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
