[
https://issues.apache.org/jira/browse/FLINK-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224339#comment-14224339
]
ASF GitHub Bot commented on FLINK-984:
--------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/61#issuecomment-64377332
I've added key expressions for distinct() as part of my pull request (See:
https://github.com/apache/incubator-flink/blob/master/flink-java/src/main/java/org/apache/flink/api/java/DataSet.java#L449)
I can manually merge the pull request and add the additional tests to the
system.
I'm going to assign the JIRA to myself to remember that I'm going to do
this.
> Distinct operator for POJO DataSets without KeySelector and on
> UnsortedGrouping
> -------------------------------------------------------------------------------
>
> Key: FLINK-984
> URL: https://issues.apache.org/jira/browse/FLINK-984
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: Markus Holzemer
> Priority: Minor
>
> Two issues regarding the distinct operator:
> - The distinct operator does not support {{distinct()}} with POJO datasets. I
> think it should be possible to implement a reflection based KeySelector which
> selects all public fields as key?
> - All other grouped operators work by {{groupBy(GROUPING).operator(...)}}
> whereas the distinct operator does {{distinct(GROUPING)}}. I think it would
> be more consistent to allow {{groupBy(GROUPING).distinct()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
