[ 
https://issues.apache.org/jira/browse/FLINK-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224795#comment-14224795
 ] 

ASF GitHub Bot commented on FLINK-1221:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/231#discussion_r20875678
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/operators/NamesTest.java ---
    @@ -60,7 +60,7 @@ public boolean filter(String value) throws Exception {
                        }
                }).output(new DiscardingOuputFormat<String>());
                JavaPlan plan = env.createProgramPlan();
    -           testForName("Filter at 
org.apache.flink.api.java.operators.NamesTest.testDefaultName(NamesTest.java:54)",
 plan);
    +           testForName("Filter at testDefaultName(NamesTest.java:54)", 
plan);
    --- End diff --
    
    Looks better :) +1


> Use program source line of invocation  as the default function name
> -------------------------------------------------------------------
>
>                 Key: FLINK-1221
>                 URL: https://issues.apache.org/jira/browse/FLINK-1221
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 0.8-incubating
>            Reporter: Stephan Ewen
>            Assignee: Robert Metzger
>            Priority: Minor
>             Fix For: 0.8-incubating
>
>
> Right now, the default function name is {{getClass().getName()}}.
> In many cases, this is not really very revealing. Using line in the source 
> code where the function is invoked is more helpful.
> This can be easily obtained by
> {code}
> Thread.getCurrentThread().getStackTrace()[0]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to