Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/248#discussion_r21429930
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManager.java
---
@@ -786,6 +786,13 @@ public static JobManager initialize(String[] args)
throws Exception {
// First, try to load global configuration
GlobalConfiguration.loadConfiguration(configDir);
+ // The configuretion does not contain a jobmanager address
+ if
(GlobalConfiguration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
null) == null) {
+ Configuration c =
GlobalConfiguration.getConfiguration();
+
c.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
InetAddress.getLocalHost().getHostName());
+ LOG.info("Setting jobmanager rpc address to " +
InetAddress.getLocalHost().getHostName());
+ GlobalConfiguration.includeConfiguration(c);
--- End diff --
I am still not a big fan of manipulating the global configuration. That is
an artifact of the singleton pattern that (which I think we should reduce and
get rid of eventually). I would pass the hostname as a proper parameter, not
through the config.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
