Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/264#issuecomment-66978329
The question is whether we want to keep the char-delimiter in the
user-facing API.
I would remove it in the long run to have the consistent data types for
record and field delimiters.
That's why I marked the char variant as deprecated and switched all
occurrences to String as we shouldn't encourage use of deprecated methods.
Alternatively, we could add a char variant for the record delimiter but I
don't think this would give a benefit for users.
Btw. if we keep the char versions the PR would still change about 40 files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
