[ 
https://issues.apache.org/jira/browse/FLINK-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267868#comment-14267868
 ] 

ASF GitHub Bot commented on FLINK-1266:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/268#discussion_r22598823
  
    --- Diff: flink-addons/flink-tachyon/pom.xml ---
    @@ -0,0 +1,109 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +  http://www.apache.org/licenses/LICENSE-2.0
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    +
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <parent>
    +           <artifactId>flink-addons</artifactId>
    +           <groupId>org.apache.flink</groupId>
    +           <version>0.9-SNAPSHOT</version>
    +           <relativePath>..</relativePath>
    +   </parent>
    +
    +   <artifactId>flink-tachyon</artifactId>
    +   <name>flink-tachyon</name>
    +
    +   <packaging>jar</packaging>
    +
    +   <!--
    +           This is a Hadoop2 only flink module.
    +   -->
    +   <dependencies>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-core</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-java-examples</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>test</scope>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.tachyonproject</groupId>
    +                   <artifactId>tachyon</artifactId>
    +                   <version>0.5.0</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.tachyonproject</groupId>
    +                   <artifactId>tachyon</artifactId>
    +                   <version>0.5.0</version>
    +                   <type>test-jar</type>
    +                   <scope>test</scope>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.eclipse.jetty</groupId>
    +                   <artifactId>jetty-util</artifactId>
    +                   <version>7.6.8.v20121106</version>
    --- End diff --
    
    I will double check what maven makes out of these two versions.
    But the Jetty version is `test` scoped and should not influence the regular 
build.
    
    it also seems that I forgot to scope the regular tachyon dependency to 
`test`.


> Generalize Flink's DistributedFileSystemClass to a Hadoop FileSystem wrapper
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-1266
>                 URL: https://issues.apache.org/jira/browse/FLINK-1266
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Minor
>
> Currently, the Hadoop's DistributedFileSystem class is somewhat hardwired 
> into the Flink DistributedFileSystem class.
> That is actually not necessary because Flink's DistributedFileSystem class is 
> only assuming Hadoop's FileSystem class.
> By generalizing the Flink DFS class, we can easily support other file systems 
> implementing the Hadoop FS class, such as the GoogleHadoopFileSystem, Tachyon 
> and others.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to