[
https://issues.apache.org/jira/browse/FLUME-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341214#comment-16341214
]
ASF GitHub Bot commented on FLUME-2957:
---------------------------------------
GitHub user adenes opened a pull request:
https://github.com/apache/flume/pull/195
FLUME-2957. Remove Guava from our public API
The only Guava class used in public API is the `ImmutableMap` in the
`org.apache.flume.Context`, `org.apache.flume.node.MaterializedConfiguration`
and `org.apache.flume.node.SimpleMaterializedConfiguration` classes.
This commit replaces these with `java.util.Map`.
Note: this is a breaking change as it modifies the return type of a method
on a public interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adenes/flume FLUME-2957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flume/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit 3232832bbfc18aa1baefa1bcd995f2dea75e857f
Author: Denes Arvay <denes@...>
Date: 2018-01-26T16:07:44Z
FLUME-2957. Remove Guava from our public API
The only Guava class used in public API is the ImmutableMap in the
org.apache.flume.Context, org.apache.flume.node.MaterializedConfiguration
and
org.apache.flume.node.SimpleMaterializedConfiguration classes.
This commit replaces these with java.util.Map.
----
> Remove Guava from our public API
> --------------------------------
>
> Key: FLUME-2957
> URL: https://issues.apache.org/jira/browse/FLUME-2957
> Project: Flume
> Issue Type: Task
> Affects Versions: 1.8.0
> Reporter: Lior Zeno
> Assignee: Denes Arvay
> Priority: Major
> Labels: breaking_change
> Fix For: 2.0.0
>
>
> Context.getParameters (flume-ng-configuration module) returns
> com.google.common.collect.ImmutableMap (Guava). We should clean our API and
> return either a native java interface or Flume's.
> In addition to the current state being a bad practice, this also means that
> we are unable to shade Guava in Flume.
> Note: Since this breaks our public API, I'll reschedule this issue to 2.0
> once we have this version managed in jira.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
