polyzos commented on PR #1230: URL: https://github.com/apache/fluss/pull/1230#issuecomment-3070416769
@drr00t Thanks for all the work.. I just took a look at this PR and because I see this grow I wanna share a few thoughts. 1. This module is about examples, but I feel like there is too much focus on data generators rather than examples 2. The focus should be on Fluss APIs, but there are too many classes and code spreading in the repo, including the use of webflux... I think keeping it focused and keeping it to the bare minimum in terms of the client should be our goal 3. Similar to Apache Flink examples (or other projects, like Pulsar - see [here](https://github.com/streamnative/examples/blob/master/clients/README.md)) the examples should implement something that covers something like a use case or a "pattern" for the user .. Similar to the docs it can be something simple like: - write/read using the Fluss client - how to perform lookups - how to scale the reader in terms of the number of buckets i.e start a thread per bucket available - column pruning examples (later with predicate pushdown) etc. The current approach although its great, feels more like something to be explained into a blog post that tries to build something, rather than examples, that can be used standalone and for users to just get up and running (mostly because they will have to navigate multiple classes, code etc.) .. Does it make sense? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
