luoyuxia commented on code in PR #1339: URL: https://github.com/apache/fluss/pull/1339#discussion_r2206999569
########## fluss-lake/fluss-lake-iceberg/pom.xml: ########## @@ -0,0 +1,90 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-lake</artifactId> + <version>0.8-SNAPSHOT</version> + </parent> + + <artifactId>fluss-lake-iceberg</artifactId> + <name>Fluss : Lake : Iceberg</name> + + <packaging>jar</packaging> + + <properties> + <iceberg.version>1.9.1</iceberg.version> + <flink.major.version>1.20</flink.major.version> Review Comment: We can move `flink.major.version` and `flink.version` into the parent module dependence managerment so that paimon and fluss can share with this. ########## fluss-lake/fluss-lake-iceberg/src/main/java/com/alibaba/fluss/lake/iceberg/IcebergLakeStorage.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.fluss.lake.iceberg; + +import com.alibaba.fluss.config.Configuration; +import com.alibaba.fluss.lake.lakestorage.LakeCatalog; +import com.alibaba.fluss.lake.lakestorage.LakeStorage; +import com.alibaba.fluss.lake.writer.LakeTieringFactory; + +/** Iceberg implementation of {@link LakeStorage}. */ +public class IcebergLakeStorage implements LakeStorage { + + private final Configuration icebergConfig; + + public IcebergLakeStorage(Configuration configuration) { + this.icebergConfig = configuration; + } + + @Override + public LakeTieringFactory<?, ?> createLakeTieringFactory() { + return null; + } + + @Override + public LakeCatalog createLakeCatalog() { + return null; Review Comment: dito ########## fluss-lake/fluss-lake-iceberg/src/main/java/com/alibaba/fluss/lake/iceberg/IcebergLakeStorage.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.fluss.lake.iceberg; + +import com.alibaba.fluss.config.Configuration; +import com.alibaba.fluss.lake.lakestorage.LakeCatalog; +import com.alibaba.fluss.lake.lakestorage.LakeStorage; +import com.alibaba.fluss.lake.writer.LakeTieringFactory; + +/** Iceberg implementation of {@link LakeStorage}. */ +public class IcebergLakeStorage implements LakeStorage { + + private final Configuration icebergConfig; + + public IcebergLakeStorage(Configuration configuration) { + this.icebergConfig = configuration; + } + + @Override + public LakeTieringFactory<?, ?> createLakeTieringFactory() { + return null; Review Comment: throw not support exception instead of return null.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
