luoyuxia commented on code in PR #1344:
URL: https://github.com/apache/fluss/pull/1344#discussion_r2234969890
##########
fluss-client/src/main/java/com/alibaba/fluss/client/lookup/PrefixKeyLookuper.java:
##########
@@ -150,9 +151,18 @@ public CompletableFuture<LookupResult> lookup(InternalRow
prefixKey) {
Long partitionId = null;
if (partitionGetter != null) {
- partitionId =
- getPartitionId(
- prefixKey, partitionGetter,
tableInfo.getTablePath(), metadataUpdater);
+ try {
+ partitionId =
+ getPartitionId(
+ prefixKey,
+ partitionGetter,
+ tableInfo.getTablePath(),
+ metadataUpdater);
+ } catch (PartitionNotExistException e) {
+ CompletableFuture<LookupResult> future = new
CompletableFuture<>();
+ future.completeExceptionally(e);
Review Comment:
Does it make sense when partition not exist, complete empty result instead
of complete exception in this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
