luoyuxia commented on code in PR #1405:
URL: https://github.com/apache/fluss/pull/1405#discussion_r2242263556
##########
fluss-lake/fluss-lake-paimon/src/main/java/com/alibaba/fluss/lake/paimon/tiering/PaimonLakeCommitter.java:
##########
@@ -74,6 +71,14 @@ public PaimonCommittable
toCommittable(List<PaimonWriteResult> paimonWriteResult
for (PaimonWriteResult paimonWriteResult : paimonWriteResults) {
committable.addFileCommittable(paimonWriteResult.commitMessage());
}
+ if (!paimonWriteResults.isEmpty()) {
+ committable.addProperty(
Review Comment:
This only add the bucket offsets for the records written in this snapshot
delta. But we definetly need the full bucket offsets since when snapshot
expire, we'll lose the previous bucket offsets .
Hopefully, we already have the full snapshot offsets in zk, we can get it
from zk and merge with current written records offset in this snapshot...
But please remember the full snapshot offsets in zk doesn't contain
partition name, but you can add it in another pr. Maybe before this pr or after
this pr. Both are fine to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
