MehulBatra commented on code in PR #1372: URL: https://github.com/apache/fluss/pull/1372#discussion_r2255422477
########## fluss-lake/fluss-lake-iceberg/src/main/java/com/alibaba/fluss/lake/iceberg/IcebergLakeCatalog.java: ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.fluss.lake.iceberg; + +import com.alibaba.fluss.config.Configuration; +import com.alibaba.fluss.exception.TableAlreadyExistException; +import com.alibaba.fluss.lake.lakestorage.LakeCatalog; +import com.alibaba.fluss.metadata.TableDescriptor; +import com.alibaba.fluss.metadata.TablePath; +import com.alibaba.fluss.types.DataType; +import com.alibaba.fluss.types.DataTypeRoot; +import com.alibaba.fluss.utils.IOUtils; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Schema; +import org.apache.iceberg.SortOrder; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.SupportsNamespaces; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.AlreadyExistsException; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; + +import static com.alibaba.fluss.metadata.TableDescriptor.BUCKET_COLUMN_NAME; +import static com.alibaba.fluss.metadata.TableDescriptor.OFFSET_COLUMN_NAME; +import static com.alibaba.fluss.metadata.TableDescriptor.TIMESTAMP_COLUMN_NAME; +import static org.apache.iceberg.CatalogUtil.loadCatalog; + +/** A Iceberg implementation of {@link LakeCatalog}. */ +public class IcebergLakeCatalog implements LakeCatalog { + + private static final LinkedHashMap<String, Type> SYSTEM_COLUMNS = new LinkedHashMap<>(); + + static { + // We need __bucket system column to filter out the given bucket + // for iceberg bucket append only table & primary key table. + SYSTEM_COLUMNS.put(BUCKET_COLUMN_NAME, Types.IntegerType.get()); + SYSTEM_COLUMNS.put(OFFSET_COLUMN_NAME, Types.LongType.get()); + SYSTEM_COLUMNS.put(TIMESTAMP_COLUMN_NAME, Types.TimestampType.withZone()); + } + + private final Catalog icebergCatalog; + + // for fluss config + private static final String FLUSS_CONF_PREFIX = "fluss."; + // for iceberg config + private static final String ICEBERG_CONF_PREFIX = "iceberg."; + + public IcebergLakeCatalog(Configuration configuration) { + // Extract Iceberg catalog properties from Fluss configuration + + this.icebergCatalog = createIcebergCatalog(configuration); + } + + private Catalog createIcebergCatalog(Configuration configuration) { + // Configuration has already been filtered by extractLakeProperties() + Map<String, String> icebergProps = configuration.toMap(); + + String catalogType = icebergProps.get("type"); + if (catalogType == null) { + throw new IllegalArgumentException( + "Missing required Iceberg catalog type. Set 'iceberg.catalog.type' in your configuration (e.g., 'hive', 'hadoop', or 'rest')."); + } + + String catalogName = icebergProps.getOrDefault("name", "fluss-iceberg-catalog"); + + return loadCatalog( + catalogType, + catalogName, + icebergProps, + null // Optional: pass Hadoop configuration if available + ); + } + + @Override + public void createTable(TablePath tablePath, TableDescriptor tableDescriptor) + throws TableAlreadyExistException { + try { + TableIdentifier icebergId = toIcebergTableIdentifier(tablePath); + + // Ensure namespace exists + createDatabase(tablePath.getDatabaseName()); Review Comment: if you check method, I have taken care in createDatabase method (create if not exists else skip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
