luoyuxia commented on code in PR #1468:
URL: https://github.com/apache/fluss/pull/1468#discussion_r2259669894
##########
fluss-server/src/main/java/com/alibaba/fluss/server/metrics/group/TabletServerMetricGroup.java:
##########
@@ -75,6 +77,7 @@ public TabletServerMetricGroup(
@Override
protected final void putVariables(Map<String, String> variables) {
variables.put("cluster_id", clusterId);
+ variables.put("rack", rack);
Review Comment:
Not put to putVariables if rack is null, otherwise, it'll cause npe in
https://github.com/apache/fluss/blob/74ab1f130a00fceb880dcf28c94e68fe5dc062ce/fluss-metrics/fluss-metrics-prometheus/src/main/java/com/alibaba/fluss/metrics/prometheus/PrometheusReporter.java#L125
##########
fluss-server/src/main/java/com/alibaba/fluss/server/metrics/ServerMetricUtils.java:
##########
@@ -79,9 +79,9 @@ public static CoordinatorMetricGroup createCoordinatorGroup(
}
public static TabletServerMetricGroup createTabletServerGroup(
- MetricRegistry registry, String clusterId, String hostname, int
serverId) {
+ MetricRegistry registry, String clusterId, String rack, String
hostname, int serverId) {
Review Comment:
```suggestion
MetricRegistry registry, String clusterId, @Nullable String
rack, String hostname, int serverId) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
