luoyuxia commented on code in PR #1416: URL: https://github.com/apache/fluss/pull/1416#discussion_r2259751006
##########
website/docs/table-design/data-types.md:
##########
@@ -25,24 +25,24 @@ sidebar_position: 10
Fluss has a rich set of native data types available to users. All the data
types of Fluss are as follows:
-| DataType |
Description
|
-|--------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| BOOLEAN | A
boolean with a (possibly) three-valued logic of TRUE, FALSE, UNKNOWN.
|
-| TINYINT | A
1-byte signed integer with values from -128 to 127.
|
-| SMALLINT | A
2-byte signed integer with values from -32,768 to 32,767.
|
-| INT | A
4-byte signed integer with values from -2,147,483,648 to 2,147,483,647.
|
-| BIGINT |
An 8-byte signed integer with values from -9,223,372,036,854,775,808 to
9,223,372,036,854,775,807.
|
-| FLOAT | A
4-byte single precision floating point number.
|
-| DOUBLE |
An 8-byte double precision floating point number.
|
-| CHAR(n) | A
fixed-length character string where n is the number of code points. n must have
a value between 1 and Integer.MAX_VALUE (both inclusive).
|
-| STRING | A
variable-length character string.
|
-| DECIMAL(p, s) | A
decimal number with fixed precision and scale where p is the number of digits
in a number (=precision) and s is the number of digits to the right of the
decimal point in a number (=scale). p must have a value between 1 and 38 (both
inclusive). s must have a value between 0 and p (both inclusive).
|
-| DATE | A
date consisting of year-month-day with values ranging from 0000-01-01 to
9999-12-31. <br/>Compared to the SQL standard, the range starts at year 0000.
|
-| TIME | A
time WITHOUT time zone with no fractional seconds by default. <br/> An instance
consists of `hour:minute:second` with up to second precision and values ranging
from 00:00:00 to 23:59:59. <br/>Compared to the SQL standard, leap seconds
(23:59:60 and 23:59:61) are not supported as the semantics are closer to
java.time.LocalTime. A time WITH time zone is not provided.
|
-| TIME(p) | A
time WITHOUT time zone where p is the number of digits of fractional seconds
(=precision). p must have a value between 0 and 9 (both inclusive).<br/> An
instance consists of `hour:minute:second[.fractional]` with up to nanosecond
precision and values ranging from 00:00:00.000000000 to 23:59:59.999999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalTime. A time WITH
time zone is not provided. |
-| TIMESTAMP | A
timestamp WITHOUT time zone with 6 digits of fractional seconds by
default.<br/> An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to microsecond precision and values
ranging from 0000-01-01 00:00:00.000000 to 9999-12-31 23:59:59.999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalDateTime.
|
-| TIMESTAMP(p) | A
timestamp WITHOUT time zone where p is the number of digits of fractional
seconds (=precision). p must have a value between 0 and 9 (both inclusive).
<br/>An instance consists of `year-month-day hour:minute:second[.fractional]`
with up to nanosecond precision and values ranging from 0000-01-01
00:00:00.000000000 to 9999-12-31 23:59:59.999999999.<br/>Compared to the SQL
standard, leap seconds (23:59:60 and 23:59:61) are not supported as the
semantics are closer to java. time. LocalDateTime. |
-| TIMESTAMP_LTZ | A
timestamp WITH time zone `TIMESTAMP WITH TIME ZONE` with 6 digits of fractional
seconds by default. <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` zone with up to microsecond precision and
values ranging from 0000-01-01 00:00:00.000000 +14:59 to 9999-12-31
23:59:59.999999 -14:59. <br/> Compared to the SQL standard, leap seconds
(23:59:60 and 23:59:61) are not supported as the semantics are closer to java.
time. OffsetDateTime.
|
-| TIMESTAMP_LTZ(p) | A
timestamp WITH time zone `TIMESTAMP WITH TIME ZONE` where p is the number of
digits of fractional seconds (=precision). p must have a value between 0 and 9
(both inclusive). <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to nanosecond precision and values
ranging from 0000-01-01 00:00:00.000000000 to 9999-12-31 23:59:59.999999999.
<br/> Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are
not supported as the semantics are closer to java. time. LocalDateTime |
-| BINARY(n) | A
fixed-length binary string (=a sequence of bytes) where n is the number of
bytes. n must have a value between 1 and Integer.MAX_VALUE (both inclusive).
|
-| BYTES | A
variable-length binary string (=a sequence of bytes).
|
+| DataType |
Description
|
+|--------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| BOOLEAN | A
boolean with a (possibly) three-valued logic of TRUE, FALSE, UNKNOWN.
|
+| TINYINT | A
1-byte signed integer with values from -128 to 127.
|
+| SMALLINT | A
2-byte signed integer with values from -32,768 to 32,767.
|
+| INT | A
4-byte signed integer with values from -2,147,483,648 to 2,147,483,647.
|
+| BIGINT |
An 8-byte signed integer with values from -9,223,372,036,854,775,808 to
9,223,372,036,854,775,807.
|
+| FLOAT | A
4-byte single precision floating point number.
|
+| DOUBLE |
An 8-byte double precision floating point number.
|
+| CHAR(n) | A
fixed-length character string where n is the number of code points. n must have
a value between 1 and Integer.MAX_VALUE (both inclusive).
|
+| STRING | A
variable-length character string.
|
+| DECIMAL(p, s) | A
decimal number with fixed precision and scale where p is the number of digits
in a number (=precision) and s is the number of digits to the right of the
decimal point in a number (=scale). p must have a value between 1 and 38 (both
inclusive). s must have a value between 0 and p (both inclusive).
|
+| DATE | A
date consisting of year-month-day with values ranging from 0000-01-01 to
9999-12-31. <br/>Compared to the SQL standard, the range starts at year 0000.
|
+| TIME | A
time WITHOUT time zone with no fractional seconds by default. <br/> An instance
consists of `hour:minute:second` with up to second precision and values ranging
from 00:00:00 to 23:59:59. <br/>Compared to the SQL standard, leap seconds
(23:59:60 and 23:59:61) are not supported as the semantics are closer to
java.time.LocalTime. A time WITH time zone is not provided.
|
+| TIME(p) | A
time WITHOUT time zone where p is the number of digits of fractional seconds
(=precision). p must have a value between 0 and 9 (both inclusive).<br/> An
instance consists of `hour:minute:second[.fractional]` with up to nanosecond
precision and values ranging from 00:00:00.000000000 to 23:59:59.999999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalTime. A time WITH
time zone is not provided. |
+| TIMESTAMP | A
timestamp WITHOUT time zone with 6 digits of fractional seconds by
default.<br/> An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to microsecond precision and values
ranging from 0000-01-01 00:00:00.000000 to 9999-12-31 23:59:59.999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalDateTime.
|
+| TIMESTAMP(p) | A
timestamp WITHOUT time zone where p is the number of digits of fractional
seconds (=precision). p must have a value between 0 and 9 (both inclusive).
<br/>An instance consists of `year-month-day hour:minute:second[.fractional]`
with up to nanosecond precision and values ranging from 0000-01-01
00:00:00.000000000 to 9999-12-31 23:59:59.999999999.<br/>Compared to the SQL
standard, leap seconds (23:59:60 and 23:59:61) are not supported as the
semantics are closer to java. time. LocalDateTime.
|
+| TIMESTAMP_LTZ | A
timestamp WITH local time zone `TIMESTAMP WITH LOCAL TIME ZONE` with 6 digits
of fractional seconds by default. <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to microsecond precision and values
ranging from 0000-01-01 00:00:00.000000000 to 9999-12-31 23:59:59.999999999.
<br/> Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are
not supported as the semantics are closer to java. time. LocalDateTime.
|
+| TIMESTAMP_LTZ(p) | A
timestamp WITH local time zone `TIMESTAMP WITH LOCAL TIME ZONE` where p is the
number of digits of fractional seconds (=precision). p must have a value
between 0 and 9 (both inclusive). <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to nanosecond precision and values
ranging from 0000-01-01 00:00:00.000000000 to 9999-12-31 23:59:59.999999999.
<br/> Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are
not supported as the semantics are closer to java. time. LocalDateTime |
Review Comment:
```suggestion
| TIMESTAMP_LTZ(p) |
A timestamp WITH local time zone `TIMESTAMP WITH LOCAL TIME ZONE` where p is
the number of digits of fractional seconds (=precision). p must have a value
between 0 and 9 (both inclusive). <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to nanosecond precision and values
ranging from 0000-01-01 00:00:00.000000000 to 9999-12-31 23:59:59.999999999.
<br/> Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are
not supported as the semantics are closer to java. time. Instant |
```
##########
website/docs/table-design/data-types.md:
##########
@@ -25,24 +25,24 @@ sidebar_position: 10
Fluss has a rich set of native data types available to users. All the data
types of Fluss are as follows:
-| DataType |
Description
|
-|--------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| BOOLEAN | A
boolean with a (possibly) three-valued logic of TRUE, FALSE, UNKNOWN.
|
-| TINYINT | A
1-byte signed integer with values from -128 to 127.
|
-| SMALLINT | A
2-byte signed integer with values from -32,768 to 32,767.
|
-| INT | A
4-byte signed integer with values from -2,147,483,648 to 2,147,483,647.
|
-| BIGINT |
An 8-byte signed integer with values from -9,223,372,036,854,775,808 to
9,223,372,036,854,775,807.
|
-| FLOAT | A
4-byte single precision floating point number.
|
-| DOUBLE |
An 8-byte double precision floating point number.
|
-| CHAR(n) | A
fixed-length character string where n is the number of code points. n must have
a value between 1 and Integer.MAX_VALUE (both inclusive).
|
-| STRING | A
variable-length character string.
|
-| DECIMAL(p, s) | A
decimal number with fixed precision and scale where p is the number of digits
in a number (=precision) and s is the number of digits to the right of the
decimal point in a number (=scale). p must have a value between 1 and 38 (both
inclusive). s must have a value between 0 and p (both inclusive).
|
-| DATE | A
date consisting of year-month-day with values ranging from 0000-01-01 to
9999-12-31. <br/>Compared to the SQL standard, the range starts at year 0000.
|
-| TIME | A
time WITHOUT time zone with no fractional seconds by default. <br/> An instance
consists of `hour:minute:second` with up to second precision and values ranging
from 00:00:00 to 23:59:59. <br/>Compared to the SQL standard, leap seconds
(23:59:60 and 23:59:61) are not supported as the semantics are closer to
java.time.LocalTime. A time WITH time zone is not provided.
|
-| TIME(p) | A
time WITHOUT time zone where p is the number of digits of fractional seconds
(=precision). p must have a value between 0 and 9 (both inclusive).<br/> An
instance consists of `hour:minute:second[.fractional]` with up to nanosecond
precision and values ranging from 00:00:00.000000000 to 23:59:59.999999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalTime. A time WITH
time zone is not provided. |
-| TIMESTAMP | A
timestamp WITHOUT time zone with 6 digits of fractional seconds by
default.<br/> An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to microsecond precision and values
ranging from 0000-01-01 00:00:00.000000 to 9999-12-31 23:59:59.999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalDateTime.
|
-| TIMESTAMP(p) | A
timestamp WITHOUT time zone where p is the number of digits of fractional
seconds (=precision). p must have a value between 0 and 9 (both inclusive).
<br/>An instance consists of `year-month-day hour:minute:second[.fractional]`
with up to nanosecond precision and values ranging from 0000-01-01
00:00:00.000000000 to 9999-12-31 23:59:59.999999999.<br/>Compared to the SQL
standard, leap seconds (23:59:60 and 23:59:61) are not supported as the
semantics are closer to java. time. LocalDateTime. |
-| TIMESTAMP_LTZ | A
timestamp WITH time zone `TIMESTAMP WITH TIME ZONE` with 6 digits of fractional
seconds by default. <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` zone with up to microsecond precision and
values ranging from 0000-01-01 00:00:00.000000 +14:59 to 9999-12-31
23:59:59.999999 -14:59. <br/> Compared to the SQL standard, leap seconds
(23:59:60 and 23:59:61) are not supported as the semantics are closer to java.
time. OffsetDateTime.
|
-| TIMESTAMP_LTZ(p) | A
timestamp WITH time zone `TIMESTAMP WITH TIME ZONE` where p is the number of
digits of fractional seconds (=precision). p must have a value between 0 and 9
(both inclusive). <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to nanosecond precision and values
ranging from 0000-01-01 00:00:00.000000000 to 9999-12-31 23:59:59.999999999.
<br/> Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are
not supported as the semantics are closer to java. time. LocalDateTime |
-| BINARY(n) | A
fixed-length binary string (=a sequence of bytes) where n is the number of
bytes. n must have a value between 1 and Integer.MAX_VALUE (both inclusive).
|
-| BYTES | A
variable-length binary string (=a sequence of bytes).
|
+| DataType |
Description
|
+|--------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| BOOLEAN | A
boolean with a (possibly) three-valued logic of TRUE, FALSE, UNKNOWN.
|
+| TINYINT | A
1-byte signed integer with values from -128 to 127.
|
+| SMALLINT | A
2-byte signed integer with values from -32,768 to 32,767.
|
+| INT | A
4-byte signed integer with values from -2,147,483,648 to 2,147,483,647.
|
+| BIGINT |
An 8-byte signed integer with values from -9,223,372,036,854,775,808 to
9,223,372,036,854,775,807.
|
+| FLOAT | A
4-byte single precision floating point number.
|
+| DOUBLE |
An 8-byte double precision floating point number.
|
+| CHAR(n) | A
fixed-length character string where n is the number of code points. n must have
a value between 1 and Integer.MAX_VALUE (both inclusive).
|
+| STRING | A
variable-length character string.
|
+| DECIMAL(p, s) | A
decimal number with fixed precision and scale where p is the number of digits
in a number (=precision) and s is the number of digits to the right of the
decimal point in a number (=scale). p must have a value between 1 and 38 (both
inclusive). s must have a value between 0 and p (both inclusive).
|
+| DATE | A
date consisting of year-month-day with values ranging from 0000-01-01 to
9999-12-31. <br/>Compared to the SQL standard, the range starts at year 0000.
|
+| TIME | A
time WITHOUT time zone with no fractional seconds by default. <br/> An instance
consists of `hour:minute:second` with up to second precision and values ranging
from 00:00:00 to 23:59:59. <br/>Compared to the SQL standard, leap seconds
(23:59:60 and 23:59:61) are not supported as the semantics are closer to
java.time.LocalTime. A time WITH time zone is not provided.
|
+| TIME(p) | A
time WITHOUT time zone where p is the number of digits of fractional seconds
(=precision). p must have a value between 0 and 9 (both inclusive).<br/> An
instance consists of `hour:minute:second[.fractional]` with up to nanosecond
precision and values ranging from 00:00:00.000000000 to 23:59:59.999999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalTime. A time WITH
time zone is not provided. |
+| TIMESTAMP | A
timestamp WITHOUT time zone with 6 digits of fractional seconds by
default.<br/> An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to microsecond precision and values
ranging from 0000-01-01 00:00:00.000000 to 9999-12-31 23:59:59.999999.
<br/>Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. LocalDateTime.
|
+| TIMESTAMP(p) | A
timestamp WITHOUT time zone where p is the number of digits of fractional
seconds (=precision). p must have a value between 0 and 9 (both inclusive).
<br/>An instance consists of `year-month-day hour:minute:second[.fractional]`
with up to nanosecond precision and values ranging from 0000-01-01
00:00:00.000000000 to 9999-12-31 23:59:59.999999999.<br/>Compared to the SQL
standard, leap seconds (23:59:60 and 23:59:61) are not supported as the
semantics are closer to java. time. LocalDateTime.
|
+| TIMESTAMP_LTZ | A
timestamp WITH local time zone `TIMESTAMP WITH LOCAL TIME ZONE` with 6 digits
of fractional seconds by default. <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to microsecond precision and values
ranging from 0000-01-01 00:00:00.000000000 to 9999-12-31 23:59:59.999999999.
<br/> Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are
not supported as the semantics are closer to java. time. LocalDateTime.
|
Review Comment:
```suggestion
| TIMESTAMP_LTZ |
A timestamp WITH local time zone `TIMESTAMP WITH LOCAL TIME ZONE` with 6 digits
of fractional seconds by default. <br/>An instance consists of `year-month-day
hour:minute:second[.fractional]` with up to microsecond precision and values
ranging from 0000-01-01 00:00:00.000000 to 9999-12-31 23:59:59.999999. <br/>
Compared to the SQL standard, leap seconds (23:59:60 and 23:59:61) are not
supported as the semantics are closer to java. time. Instant.
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
