wuchong commented on code in PR #1466:
URL: https://github.com/apache/fluss/pull/1466#discussion_r2265209514
##########
website/docs/maintenance/observability/monitor-metrics.md:
##########
@@ -337,7 +337,7 @@ Some metrics might not be exposed when using other JVM
implementations (e.g. IBM
</tr>
<tr>
<td>eventProcessingTimeMs</td>
- <td>The time that an event took to be processed.</td>
+ <td>The time that an event took to be processed by the coordinator event
processor. This metric is labeled with <code>event_type</code> to distinguish
between different types of coordinator events.</td>
Review Comment:
I think currently the `eventProcessingTimeMs` is not directly under the
`coordinator` group, but has an infix of `event`. Could you verify that and
update the table?
##########
website/docs/maintenance/observability/monitor-metrics.md:
##########
@@ -327,7 +327,7 @@ Some metrics might not be exposed when using other JVM
implementations (e.g. IBM
</tr>
<tr>
<td>eventQueueSize</td>
- <td>The number of events waiting to be processed in the queue.</td>
+ <td>The number of events currently waiting to be processed in the
coordinator event queue. This metric is labeled with <code>event_type</code> to
distinguish between different types of coordinator events.</td>
Review Comment:
We should also update the `eventQueueSize`. Currently there are 2 metrics
for `eventQueueSize`, one is directly under `coordinator` which reports the
total queue size without `event_type` label. The other reports under the
`event` infix with the `event_type` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
