luoyuxia commented on code in PR #1508:
URL: https://github.com/apache/fluss/pull/1508#discussion_r2269500488
##########
fluss-lake/fluss-lake-iceberg/src/main/java/com/alibaba/fluss/lake/iceberg/IcebergLakeCatalog.java:
##########
@@ -145,10 +143,11 @@ private void createTable(TablePath tablePath,
Catalog.TableBuilder tableBuilder)
}
}
- public Schema convertToIcebergSchema(TableDescriptor tableDescriptor) {
+ public Schema convertToIcebergSchema(TableDescriptor tableDescriptor,
boolean isPkTable) {
Review Comment:
I feel it may be over-design, I think `isPkTable` is also self explaining
and simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
