beryllw commented on code in PR #1527:
URL: https://github.com/apache/fluss/pull/1527#discussion_r2271856865
##########
fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/lake/LakeSplitReaderGenerator.java:
##########
@@ -46,28 +49,31 @@
public class LakeSplitReaderGenerator {
private final Table table;
- private final Connection connection;
private final TablePath tablePath;
private FileStoreTable fileStoreTable;
private final @Nullable int[] projectedFields;
+ private final @Nullable LakeSource<LakeSplit> lakeSource;
public LakeSplitReaderGenerator(
Table table,
- Connection connection,
TablePath tablePath,
- @Nullable int[] projectedFields) {
+ @Nullable int[] projectedFields,
+ @Nullable LakeSource<LakeSplit> lakeSource) {
this.table = table;
- this.connection = connection;
this.tablePath = tablePath;
this.projectedFields = projectedFields;
+ this.lakeSource = lakeSource;
}
public void addSplit(SourceSplitBase split, Queue<SourceSplitBase>
boundedSplits) {
if (split instanceof PaimonSnapshotSplit) {
boundedSplits.add(split);
} else if (split instanceof PaimonSnapshotAndFlussLogSplit) {
boundedSplits.add(split);
+ } else if (split instanceof LakeSnapshotSplit) {
Review Comment:
Maybe we can remove this, as the default behavior is to `throw new
UnsupportedOperationException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
