xx789633 commented on code in PR #1441:
URL: https://github.com/apache/fluss/pull/1441#discussion_r2278941429
##########
fluss-lake/fluss-lake-lance/src/main/java/com/alibaba/fluss/lake/lance/LanceConfig.java:
##########
@@ -130,24 +130,8 @@ public static WriteParams
genWriteParamsFromConfig(LanceConfig config) {
return builder.build();
}
- private static Map<String, String> genStorageOptions(LanceConfig config) {
Review Comment:
Indeed. These changes are copied from Lance-spark. We also realized that
problem. It's error-prone to enumerate all possible storage options and pass
them down one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
