xx789633 commented on code in PR #1441:
URL: https://github.com/apache/fluss/pull/1441#discussion_r2281414730
##########
fluss-lake/fluss-lake-lance/src/main/java/com/alibaba/fluss/lake/lance/LanceConfig.java:
##########
@@ -37,12 +37,6 @@ public class LanceConfig implements Serializable {
private static final String max_row_per_file = "max_row_per_file";
private static final String max_rows_per_group = "max_rows_per_group";
private static final String max_bytes_per_file = "max_bytes_per_file";
- private static final String ak = "access_key_id";
- private static final String sk = "secret_access_key";
- private static final String endpoint = "aws_endpoint";
- private static final String region = "aws_region";
Review Comment:
As commented above by jackye1995, previously we just check the storage
options one by one, including endpoint, aksk, and region, and pass them down to
Lance API. Now we just refactor this code to skip the check and pass the whole
thing as storage options to Lance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
