luoyuxia commented on code in PR #1555:
URL: https://github.com/apache/fluss/pull/1555#discussion_r2283914516
##########
fluss-lake/fluss-lake-iceberg/src/main/java/com/alibaba/fluss/lake/iceberg/tiering/IcebergLakeCommitter.java:
##########
@@ -147,11 +147,9 @@ private void addFlussProperties(
@Override
public void abort(IcebergCommittable committable) {
- List<String> filesToDelete =
- committable.getDataFiles().stream()
- .map(dataFile -> dataFile.path().toString())
- .collect(Collectors.toList());
- CatalogUtil.deleteFiles(icebergTable.io(), filesToDelete, "data file",
true);
+ Stream.concat(committable.getDataFiles().stream(),
committable.getDeleteFiles().stream())
Review Comment:
Why not use `CatalogUtil.deleteFiles`, there are some optimization for
delete in `CatalogUtil.deleteFiles` such as bulk delete, concurrent delete..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
