LB-Yu commented on PR #1509: URL: https://github.com/apache/fluss/pull/1509#issuecomment-3213403173
> @luoyuxia @LB-Yu , thanks for your comments. I agreed. > > Then we need to re-design it a little bit, this is what I think: > > 1. we need a fluss version table changes class, (e.g.`FlussTableChanges`) to define the Fluss table changes. > 2. In `alterTable` function, to avoid pass whole `TableDescriptor`, we can only pass list of `FlussTableChanges` list to server. And then the server do altering based on different table change types. > `alterTable(TablePath tablePath, List<FlussTableChanges> tableChanges, boolean ignoreIfNotExists)`. In this ticket, we only support `SetOptions` type. > > Is that good? If yes, I will modify the implementation. @gyang94 would you like to fire a FIP? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
