Copilot commented on code in PR #1520:
URL: https://github.com/apache/fluss/pull/1520#discussion_r2296997943
##########
fluss-lake/fluss-lake-iceberg/pom.xml:
##########
@@ -227,6 +227,56 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <!-- compilation of main sources -->
+ <skipMain>${skip.on.java8}</skipMain>
+ <!-- compilation of test sources -->
+ <skip>${skip.on.java8}</skip>
Review Comment:
The configuration skips compilation on Java 8, but the PR description states
the goal is to support compilation with JDK 8. This appears contradictory - if
Iceberg 1.9.1 is chosen specifically for JDK 8 compatibility, the build should
not skip compilation on Java 8.
```suggestion
<!-- Removed skipMain to allow compilation on Java 8 -->
<!-- compilation of test sources -->
<!-- Removed skip to allow test compilation on Java 8 -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
