MehulBatra commented on code in PR #1584:
URL: https://github.com/apache/fluss/pull/1584#discussion_r2298030943
##########
fluss-lake/fluss-lake-iceberg/src/main/java/com/alibaba/fluss/lake/iceberg/tiering/IcebergLakeCommitter.java:
##########
@@ -237,20 +243,15 @@ private Snapshot getCommittedLatestSnapshotOfLake(String
commitUser) {
icebergTable.refresh();
// Find the latest snapshot committed by Fluss
- Iterable<Snapshot> snapshots = icebergTable.snapshots();
- Snapshot latestFlussSnapshot = null;
-
+ List<Snapshot> snapshots = (List<Snapshot>) icebergTable.snapshots();
Review Comment:
good to add comment for reference:
// snapshots() returns snapshots in chronological order (oldest to newest),
Reverse to find most recent snapshot committed by Fluss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
