caozhen1937 commented on code in PR #1613:
URL: https://github.com/apache/fluss/pull/1613#discussion_r2323981313
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/enumerator/initializer/NoStoppingOffsetsInitializer.java:
##########
@@ -37,6 +39,6 @@ public Map<Integer, Long> getBucketOffsets(
@Nullable String partitionName,
Collection<Integer> buckets,
OffsetsInitializer.BucketOffsetsRetriever bucketOffsetsRetriever) {
- return buckets.stream().collect(Collectors.toMap(x -> x, x ->
Long.MAX_VALUE));
+ return buckets.stream().collect(Collectors.toMap(x -> x, x ->
NO_STOPPING_OFFSET));
Review Comment:
I think changing to `MIN_VALUE` may affect the union read operation of the
log table in stream mode.
https://github.com/apache/fluss/blob/ab841ba2eb0dc94909a5847152fe5a5154e1b3ad/fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/lake/LakeSplitGenerator.java#L243C21-L249C58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@fluss.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
