Copilot commented on code in PR #1661:
URL: https://github.com/apache/fluss/pull/1661#discussion_r2331931611
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/append/AppendOnlyWriter.java:
##########
@@ -56,6 +60,11 @@ public void write(LogRecord record) throws Exception {
// hacky, call internal method tableWrite.getWrite() to support
// to write to given partition, otherwise, it'll always extract a
partition from Paimon row
// which may be costly
- tableWrite.getWrite().write(partition, bucket, flussRecordAsPaimonRow);
+ int writtenBucket = bucket;
+ // if unaware bucket mode, we have to use bucket = 0 to write to
follow paimon best practice
Review Comment:
[nitpick] The comment uses "unaware bucket mode" which is inconsistent with
the enum value `BUCKET_UNAWARE`. Consider updating to "bucket-unaware mode" for
clarity and consistency.
```suggestion
// if bucket-unaware mode, we have to use bucket = 0 to write to
follow paimon best practice
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@fluss.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
