xx789633 commented on code in PR #1658:
URL: https://github.com/apache/fluss/pull/1658#discussion_r2332254024


##########
fluss-lake/fluss-lake-iceberg/src/test/java/org/apache/fluss/lake/iceberg/maintenance/IcebergRewriteITCase.java:
##########
@@ -48,6 +54,277 @@ protected static void beforeAll() {
         execEnv.enableCheckpointing(1000);
     }
 
+    @Test
+    void testPosDeleteCompaction() throws Exception {
+        JobClient jobClient = buildTieringJob(execEnv);
+        try {
+            TablePath t1 = TablePath.of(DEFAULT_DB, "pk_table_1");
+            long t1Id = createPkTable(t1, true);
+            TableBucket t1Bucket = new TableBucket(t1Id, 0);
+
+            List<InternalRow> rows =

Review Comment:
   Or you can create a function that encapsulates the rows record generation if 
you don't want to reuse the existing full type pk table :)



##########
fluss-lake/fluss-lake-iceberg/src/test/java/org/apache/fluss/lake/iceberg/maintenance/IcebergRewriteITCase.java:
##########
@@ -48,6 +54,277 @@ protected static void beforeAll() {
         execEnv.enableCheckpointing(1000);
     }
 
+    @Test
+    void testPosDeleteCompaction() throws Exception {
+        JobClient jobClient = buildTieringJob(execEnv);
+        try {
+            TablePath t1 = TablePath.of(DEFAULT_DB, "pk_table_1");
+            long t1Id = createPkTable(t1, true);
+            TableBucket t1Bucket = new TableBucket(t1Id, 0);
+
+            List<InternalRow> rows =

Review Comment:
   Or you can create a function that encapsulates the rows record generation if 
you want to reuse the existing full type pk table :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@fluss.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to