luoyuxia commented on code in PR #1686:
URL: https://github.com/apache/fluss/pull/1686#discussion_r2342874680
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1640,8 +1641,8 @@ public class ConfigOptions {
.enumType(DataLakeFormat.class)
.noDefaultValue()
.withDescription(
- "The datalake format used by Fluss to be as lake
storage, such as Paimon, Iceberg, Hudi. "
- + "Now, only support Paimon.");
+ "The datalake format used by of Fluss to be as
lakehouse storage. Currently, supported formats are Paimon, Iceberg, and Lance.
"
+ + "In the future, more kinds of data lake
format will be supported, such as DeltaLake or Hudi. ");
Review Comment:
dito
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1293,11 +1293,12 @@ public class ConfigOptions {
.enumType(DataLakeFormat.class)
.noDefaultValue()
.withDescription(
- "The data lake format of the table specifies the
tiered Lakehouse storage format, such as Paimon, Iceberg, DeltaLake, or Hudi.
Currently, only `paimon` is supported. "
+ "The data lake format of the table specifies the
tiered Lakehouse storage format. Currently, supported formats are `paimon`,
`iceberg`, and `lance`. "
+ + "In the future, more kinds of data lake
format will be supported, such as DeltaLake or Hudi. "
+ "Once the `table.datalake.format`
property is configured, Fluss adopts the key encoding and bucketing strategy
used by the corresponding data lake format. "
+ "This ensures consistency in key
encoding and bucketing, enabling seamless **Union Read** functionality across
Fluss and Lakehouse. "
+ "The `table.datalake.format` can be
pre-defined before enabling `table.datalake.enabled`. This allows the data lake
feature to be dynamically enabled on the table without requiring table
recreation. "
- + "If `table.datalake.format` is not
explicitly set during table creation, the table will default to the format
specified by the `datalake.format` configuration in the Fluss cluster.");
+ + "If `table.datalake.format` is not
explicitly set during table creation, the table will default to the format
specified by the `datalake.format` configuration in the Fluss cluster. ");
Review Comment:
nit:
remove the blank at the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
