swuferhong commented on PR #1546: URL: https://github.com/apache/fluss/pull/1546#issuecomment-3290311599
> @LiebingYu @swuferhong , this fix looks a bit hack and complex and error-prone. IIUC, this problem only occurs in JDK8, and this problem has been fixed since JDK9. Considering, we have deprecated Java8, and most case won't have this problem. If this doesn't happen commonly, I suggest do not fix it. > > Another simple fix is moving the `connection.whenClose` callback invocation to an executor service (e.g., the `eventGroup` in `NettyClient`), so there won't be deadlocks. +1 for won't fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
