wuchong commented on code in PR #1698: URL: https://github.com/apache/fluss/pull/1698#discussion_r2347960620
########## website/docs/maintenance/operations/upgrade-notes-0.8.md: ########## @@ -27,6 +27,25 @@ Please also upgrade your Flink deployment to **Java 11 or above**. All Flink ver We have updated the report level for some metrics and also removed some metrics, this greatly reduces the metrics amount and improves the performance. -The following metrics are removed: TODO - -The following metrics are changed: TODO \ No newline at end of file +The following metrics are removed: + +1. `fluss_tabletserver_table_bucket_inSyncReplicasCount` - Removed as redundant. Use `fluss_tabletserver_underReplicated` instead +2. `fluss_tabletserver_table_bucket_log_size` +3. `fluss_table_bucket_kv_snapshot_latestSnapshotSize` Review Comment: Do we have replacement for these metrics? ########## website/docs/maintenance/operations/upgrade-notes-0.8.md: ########## @@ -27,6 +27,25 @@ Please also upgrade your Flink deployment to **Java 11 or above**. All Flink ver We have updated the report level for some metrics and also removed some metrics, this greatly reduces the metrics amount and improves the performance. -The following metrics are removed: TODO - -The following metrics are changed: TODO \ No newline at end of file +The following metrics are removed: + +1. `fluss_tabletserver_table_bucket_inSyncReplicasCount` - Removed as redundant. Use `fluss_tabletserver_underReplicated` instead +2. `fluss_tabletserver_table_bucket_log_size` +3. `fluss_table_bucket_kv_snapshot_latestSnapshotSize` + +The following metrics are changed: + +1. The reporting level has been shifted from the `tableBucket` level to the `tabletserver` level: Review Comment: Let's use unordered list `-` instead of number list, the number is a little verbose in the page. <img width="1134" height="1420" alt="image" src="https://github.com/user-attachments/assets/f9ed7ae7-4cd4-4d7a-a309-7f1b887e54e4"; /> ########## website/docs/maintenance/operations/upgrade-notes-0.8.md: ########## @@ -27,6 +27,25 @@ Please also upgrade your Flink deployment to **Java 11 or above**. All Flink ver We have updated the report level for some metrics and also removed some metrics, this greatly reduces the metrics amount and improves the performance. -The following metrics are removed: TODO - -The following metrics are changed: TODO \ No newline at end of file +The following metrics are removed: + +1. `fluss_tabletserver_table_bucket_inSyncReplicasCount` - Removed as redundant. Use `fluss_tabletserver_underReplicated` instead +2. `fluss_tabletserver_table_bucket_log_size` +3. `fluss_table_bucket_kv_snapshot_latestSnapshotSize` + +The following metrics are changed: + +1. The reporting level has been shifted from the `tableBucket` level to the `tabletserver` level: + - `fluss_tabletserver_table_bucket_underMinIsr` to `fluss_tabletserver_underMinIsr` + - `fluss_tabletserver_table_bucket_underReplicated` to `fluss_tabletserver_underReplicated` + - `fluss_tabletserver_table_bucket_atMinIsr` to `fluss_tabletserver_atMinIsr` + - `fluss_tabletserver_table_bucket_isrExpandsPerSecond` to `fluss_tabletserver_isrExpandsPerSecond` + - `fluss_tabletserver_table_bucket_isrShrinksPerSecond` to `fluss_tabletserver_isrShrinksPerSecond` + - `fluss_tabletserver_table_bucket_failedIsrUpdatesPerSecond` to `fluss_tabletserver_failedIsrUpdatesPerSecond` + - `fluss_tabletserver_table_bucket_log_flushPerSecond` to `fluss_tabletserver_logFlushPerSecond` + - `fluss_tabletserver_table_bucket_log_flushLatencyMs` to `fluss_tabletserver_logFlushLatencyMs` + - `fluss_tabletserver_table_bucket_kv_preWriteBufferFlushPerSecond` to `fluss_tabletserver_kvFlushPerSecond` + - `fluss_tabletserver_table_bucket_kv_preWriteBufferFlushLatencyMs` to `fluss_tabletserver_kvFlushLatencyMs` + - `fluss_tabletserver_table_bucket_kv_preWriteBufferTruncateAsDuplicatedPerSecond` to `fluss_tabletserver_preWriteBufferTruncateAsDuplicatedPerSecond` + - `fluss_tabletserver_table_bucket_kv_preWriteBufferTruncateAsErrorPerSecond` to `fluss_tabletserver_preWriteBufferTruncateAsErrorPerSecond` +2. This correction addresses reporting errors in metric names by changing the `table` level metric prefix from `fluss_tabletserver_table__` (used a double underscore (__)) to `fluss_tabletserver_table_`. For example, change `fluss_tabletserver_table__messagesInPerSecond` to `fluss_tabletserver_table_messagesInPerSecond`. Review Comment: Is there any other metrics that has this change? We can add a link to point to the affected metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
