beryllw commented on code in PR #1725:
URL: https://github.com/apache/fluss/pull/1725#discussion_r2362135645
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/mergetree/MergeTreeWriter.java:
##########
@@ -55,8 +60,20 @@ public MergeTreeWriter(
}
private static TableWriteImpl<KeyValue> createTableWrite(FileStoreTable
fileStoreTable) {
+ // we allow users to configure the temporary directory used by fluss
tiering
+ // since the default java.io.tmpdir may not be suitable.
+ // currently, we don't expose the option, as a workaround way, maybe
in the future we can
+ // expose it if it's needed
+ Map<String, String> props = fileStoreTable.options();
+ String tmpDir = props.get(FLUSS_TIERING_TMP_DIR_KEY);
+ if (tmpDir == null) {
Review Comment:
May be we could use `getOrDefault`.
```
String tmpDir = props.getOrDefault(FLUSS_TIERING_TMP_DIR_KEY,
System.getProperty("java.io.tmpdir"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
