lsyldliu commented on code in PR #862:
URL: https://github.com/apache/fluss/pull/862#discussion_r2362102439
##########
fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/utils/FlinkConversions.java:
##########
@@ -185,13 +215,25 @@ public static TableDescriptor
toFlussTable(ResolvedCatalogTable catalogTable) {
"Metadata column " + col + " is not
supported.");
});
+ CatalogBaseTable.TableKind tableKind = catalogBaseTable.getTableKind();
+ List<String> partitionKeys =
+ CatalogBaseTable.TableKind.TABLE == tableKind
+ ? ((ResolvedCatalogTable)
catalogBaseTable).getPartitionKeys()
+ : ((ResolvedCatalogMaterializedTable)
catalogBaseTable).getPartitionKeys();
+
Map<String, String> customProperties = flinkTableConf.toMap();
CatalogPropertiesUtils.serializeComputedColumns(
customProperties, resolvedSchema.getColumns());
CatalogPropertiesUtils.serializeWatermarkSpecs(
- customProperties,
catalogTable.getResolvedSchema().getWatermarkSpecs());
+ customProperties,
catalogBaseTable.getResolvedSchema().getWatermarkSpecs());
- String comment = catalogTable.getComment();
+ // Set materialized table flags to fluss table custom properties
+ if (CatalogBaseTable.TableKind.MATERIALIZED_TABLE == tableKind) {
+ serializeMaterializedTableToCustomProperties(
Review Comment:
This is a good question, but it is unexpected behavior, currently we can't
control the user action, and these options are internal, user shouldn't see it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
