luoyuxia commented on code in PR #1732:
URL: https://github.com/apache/fluss/pull/1732#discussion_r2366615829
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/source/PaimonSplitPlanner.java:
##########
@@ -67,12 +67,14 @@ public List<PaimonSplit> plan() {
try (Catalog catalog = getCatalog()) {
FileStoreTable fileStoreTable = getTable(catalog, tablePath,
snapshotId);
InnerTableScan tableScan = fileStoreTable.newScan();
+ boolean isBucketAware = isBucketAware(fileStoreTable);
Review Comment:
```suggestion
boolean isBucketAware = fileStoreTable.bucketMode() ==
BucketMode.BUCKET_UNAWARE;
```
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/source/PaimonSplitSerializer.java:
##########
@@ -26,14 +26,20 @@
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
import java.io.IOException;
/** Serializer for paimon split. */
public class PaimonSplitSerializer implements
SimpleVersionedSerializer<PaimonSplit> {
+ // Version 1: Original version with only DataSplit
+ // Version 2: Added isBucketAware field for bucket-unaware table support
+ private static final int VERSION_1 = 1;
Review Comment:
we can just keep the version as still 1 since 0.8 is the only one version
that introduces `PaimonSplitSerializer`, we do change any thing during 0.8.
But once 0.8 is released, any change in `PaimonSplitSerializer` should keep
compatibility. But now, we don't need compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
