Copilot commented on code in PR #1522:
URL: https://github.com/apache/fluss/pull/1522#discussion_r2371571093
##########
fluss-filesystems/fluss-fs-hadoop/src/main/java/org/apache/fluss/fs/hdfs/HadoopFileSystem.java:
##########
@@ -37,11 +35,7 @@
/**
* A {@link FileSystem} that wraps an {@link org.apache.hadoop.fs.FileSystem
Hadoop File System}.
Review Comment:
The class is now abstract but lacks documentation explaining why it's
abstract and what subclasses need to implement. Add class-level documentation
to clarify the purpose and requirements for subclasses.
```suggestion
* An abstract {@link FileSystem} implementation that wraps a {@link
org.apache.hadoop.fs.FileSystem Hadoop File System}.
* <p>
* This class serves as a base for file system implementations that delegate
their operations to a Hadoop file system.
* It provides concrete implementations for most file system operations by
forwarding them to the underlying Hadoop file system.
* <p>
* <b>Subclass requirements:</b>
* <ul>
* <li>Subclasses must implement any abstract methods inherited from
{@link FileSystem} that are not implemented here.</li>
* <li>Subclasses may provide additional configuration or behavior
specific to the particular Hadoop file system being wrapped.</li>
* </ul>
* <p>
* The wrapped Hadoop file system instance must be fully initialized before
being passed to this class.
```
##########
fluss-filesystems/fluss-fs-hdfs/src/main/java/org/apache/fluss/fs/hdfs/HdfsPlugin.java:
##########
@@ -33,22 +33,18 @@
import static org.apache.fluss.utils.Preconditions.checkArgument;
import static org.apache.fluss.utils.Preconditions.checkNotNull;
-/* This file is based on source code of Apache Flink Project
(https://flink.apache.org/), licensed by the Apache
- * Software Foundation (ASF) under the Apache License, Version 2.0. See the
NOTICE file distributed with this work for
- * additional information regarding copyright ownership. */
-
/**
* A file system plugin for Hadoop-based file systems.
*
* <p>This plugin calls Hadoop's mechanism to find a file system
implementation for a given file
* system scheme (a {@link org.apache.hadoop.fs.FileSystem}) and wraps it as a
Fluss file system (a
Review Comment:
The class documentation refers to 'Hadoop-based file systems' but this is
now specifically an HDFS plugin. Update the documentation to reflect that this
is specifically for HDFS file systems.
```suggestion
* A file system plugin for HDFS (Hadoop Distributed File System).
*
* <p>This plugin uses Hadoop's mechanism to find an HDFS file system
implementation
* (a {@link org.apache.hadoop.fs.FileSystem}) and wraps it as a Fluss file
system (a
```
##########
fluss-filesystems/fluss-fs-hdfs/src/main/java/org/apache/fluss/fs/hdfs/HdfsFileSystem.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.fluss.fs.hdfs;
+
+import org.apache.fluss.fs.FileSystem;
+import org.apache.fluss.fs.token.ObtainedSecurityToken;
+
+import java.io.IOException;
+import java.util.Collections;
+
+/**
+ * A {@link FileSystem} for HDFS that wraps an {@link HadoopFileSystem}, but
overwrite method to
Review Comment:
Change 'overwrite method' to 'overrides methods' for correct grammar.
```suggestion
* A {@link FileSystem} for HDFS that wraps an {@link HadoopFileSystem}, but
overrides method to
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
