rionmonster commented on PR #1748:
URL: https://github.com/apache/fluss/pull/1748#issuecomment-3326239020
**Alternative Consideration**
It's probably worth mentioning that I considered a few options prior to
issuing this PR but the primary alternative felt a bit heavy-handed, but I'm
open to changing things. The alternative consisted of introducing a private
static class that would be responsible for performing a single pass over the
configuration keys and identify each category during that iteration.
Something like the following along with a corresponding static function
responsible for the extraction of those categories (e.g.
`extractPropertyCategories(Configuration options)`) that would then expose each
specific category:
```
private static class PropertyCategories {
// allProperties probably not necessary here as the table only consumes
table and custom properties
final Map<String, String> allProperties;
final Map<String, String> tableProperties;
final Map<String, String> customProperties;
...
}
```
This would remove the key-wise comparison between all of the current
properties with the table properties (which should be fairly inexpensive on its
own).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
