LiebingYu commented on code in PR #1655:
URL: https://github.com/apache/fluss/pull/1655#discussion_r2386821052
##########
fluss-server/src/main/java/org/apache/fluss/server/tablet/TabletServer.java:
##########
@@ -202,7 +202,10 @@ protected void startServices() throws Exception {
// rpc client to sent request to the tablet server where the
leader replica is located
// to fetch log.
this.clientMetricGroup =
- new ClientMetricGroup(metricRegistry, SERVER_NAME + "-" +
serverId);
+ new ClientMetricGroup(
+ metricRegistry,
+ ServerMetricUtils.validateAndGetClusterId(conf),
+ SERVER_NAME + "-" + serverId);
Review Comment:
> It seems more like `server_id` rather than `cluster_id`? Different server
in same cluster will collect different viriable.
`server_id` has already been added. Here I want to add `cluster_id` for
client metric. The `cluster_id` is necessary when troubleshooting issues, for
example, when examining metrics related to requests sent by the
`ReplicaFetcherThread`. Currently, since the client metrics do not have a
`cluster_id` label, we are unable to distinguish metrics from different
clusters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
