naivedogger commented on code in PR #9: URL: https://github.com/apache/fluss-rust/pull/9#discussion_r2426968389
########## bindings/python/src/table.rs: ########## @@ -0,0 +1,474 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use pyo3::prelude::*; +use crate::*; +use std::sync::Arc; +use pyo3_async_runtimes::tokio::future_into_py; +use crate::TOKIO_RUNTIME; + +/// Represents a Fluss table for data operations +#[pyclass] +pub struct FlussTable { + connection: Arc<fcore::client::FlussConnection>, + metadata: Arc<fcore::client::Metadata>, + table_info: fcore::metadata::TableInfo, + table_path: fcore::metadata::TablePath, + has_primary_key: bool, +} + +#[pymethods] +impl FlussTable { + /// Create a new append writer for the table + fn new_append_writer<'py>(&self, py: Python<'py>) -> PyResult<Bound<'py, PyAny>> { + let conn = self.connection.clone(); + let metadata = self.metadata.clone(); + let table_info = self.table_info.clone(); + + future_into_py(py, async move { + let fluss_table = fcore::client::FlussTable::new( + &conn, + metadata, + table_info, + ); + + let table_append = fluss_table.new_append() + .map_err(|e| FlussError::new_err(e.to_string()))?; + + let rust_writer = table_append.create_writer(); + + let py_writer = AppendWriter::from_core(rust_writer); + + Python::with_gil(|py| { + Py::new(py, py_writer) + }) + }) + } + + /// Create a new log scanner for the table + // Note: LogScanner is not Send, so this may cause issues in async contexts Review Comment: Maybe I'm mistaken, but I recall encountering an issue related to this... However, it seems that the LogScanner is actually 'Send' now. I tried in my local environment simply removing the 'unsendable' annotation in line #300, and the async method for creating log_scanner works fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
