Copilot commented on code in PR #1774: URL: https://github.com/apache/fluss/pull/1774#discussion_r2390015121
########## website/docs/streaming-lakehouse/integrate-data-lakes/iceberg.md: ########## @@ -406,6 +406,40 @@ All Iceberg tables created by Fluss include three system columns: ## Read Tables +### Reading with Apache Flink + +For a table with the option 'table.datalake.enabled' = 'true', its data exists in two layers: one remains in Fluss, and the other has already been tiered to Iceberg. +You can have a combined view of both Fluss and Iceberg data, which provides second-level latency but may result in slightly degraded query performance. +Read data only from Iceberg not supported now. + +#### Union Read of Data in Fluss and Iceberg + +##### Prerequisites + +Prepare flink environment. See the [🚀 Start Tiering Service to Iceberg](#-start-datalake-tiering-service) for detailed instructions. + +##### Union Read + +To read the full dataset, which includes both Fluss (fresh) and Iceberg (historical) data, simply query the table without any suffix. The following example illustrates this: + +```sql +-- Set execution mode to streaming or batch, here just take batch as an example +SET 'execution.runtime-mode' = 'streaming'; + +-- Query will union data from Fluss and Paimon Review Comment: The comment mentions 'Paimon' but this documentation is about Iceberg integration. It should say 'Query will union data from Fluss and Iceberg'. ```suggestion -- Query will union data from Fluss and Iceberg ``` ########## website/docs/streaming-lakehouse/integrate-data-lakes/iceberg.md: ########## @@ -406,6 +406,40 @@ All Iceberg tables created by Fluss include three system columns: ## Read Tables +### Reading with Apache Flink + +For a table with the option 'table.datalake.enabled' = 'true', its data exists in two layers: one remains in Fluss, and the other has already been tiered to Iceberg. +You can have a combined view of both Fluss and Iceberg data, which provides second-level latency but may result in slightly degraded query performance. +Read data only from Iceberg not supported now. Review Comment: The sentence has grammatical issues. It should be 'Reading data only from Iceberg is not supported now.' or 'Reading data only from Iceberg is not currently supported.' ```suggestion Reading data only from Iceberg is not supported now. ``` ########## website/docs/streaming-lakehouse/integrate-data-lakes/iceberg.md: ########## @@ -406,6 +406,40 @@ All Iceberg tables created by Fluss include three system columns: ## Read Tables +### Reading with Apache Flink + +For a table with the option 'table.datalake.enabled' = 'true', its data exists in two layers: one remains in Fluss, and the other has already been tiered to Iceberg. +You can have a combined view of both Fluss and Iceberg data, which provides second-level latency but may result in slightly degraded query performance. +Read data only from Iceberg not supported now. + +#### Union Read of Data in Fluss and Iceberg + +##### Prerequisites + +Prepare flink environment. See the [🚀 Start Tiering Service to Iceberg](#-start-datalake-tiering-service) for detailed instructions. + +##### Union Read + +To read the full dataset, which includes both Fluss (fresh) and Iceberg (historical) data, simply query the table without any suffix. The following example illustrates this: + +```sql +-- Set execution mode to streaming or batch, here just take batch as an example +SET 'execution.runtime-mode' = 'streaming'; + +-- Query will union data from Fluss and Paimon +select avg(total_price) from fluss_order; +``` + +It supports both batch and streaming modes, using Iceberg for historical data and Fluss for fresh data: + +- In batch mode (only log table) + +- In streaming mode(pk table and log table) Review Comment: Missing space before the opening parenthesis in 'streaming mode(pk table'. It should be 'streaming mode (pk table and log table)'. ```suggestion - In streaming mode (pk table and log table) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
