LiebingYu commented on code in PR #1452:
URL: https://github.com/apache/fluss/pull/1452#discussion_r2454392781
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java:
##########
@@ -762,7 +791,30 @@ public CompletableFuture<RemoveServerTagResponse>
removeServerTag(
@Override
public CompletableFuture<RebalanceResponse> rebalance(RebalanceRequest
request) {
- throw new UnsupportedOperationException("Support soon!");
+ List<Goal> goalsByPriority = new ArrayList<>();
Review Comment:
Missing permission control?
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java:
##########
@@ -774,7 +826,8 @@ public CompletableFuture<ListRebalanceProcessResponse>
listRebalanceProcess(
@Override
public CompletableFuture<CancelRebalanceResponse> cancelRebalance(
CancelRebalanceRequest request) {
- throw new UnsupportedOperationException("Support soon!");
+ rebalanceManagerSupplier.get().cancelRebalance();
Review Comment:
ditto
##########
fluss-server/src/main/java/org/apache/fluss/server/zk/data/LeaderAndIsr.java:
##########
@@ -93,6 +93,10 @@ public LeaderAndIsr newLeaderAndIsr(List<Integer> newIsr) {
return new LeaderAndIsr(leader, leaderEpoch, newIsr, coordinatorEpoch,
bucketEpoch + 1);
}
+ public LeaderAndIsr newLeaderAndIsrWithNewLeaderEpoch() {
Review Comment:
Seems no usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
