rionmonster opened a new pull request, #1881:
URL: https://github.com/apache/fluss/pull/1881

   ### Purpose
   
   Linked issue: close #1873 
   
   Per Issue https://github.com/apache/fluss/issues/1873, this pull request 
addresses a race condition that could sometimes occur and result in the 
`ReplicaTest.testBrokenSnapshotRecovery` test case failing (particularly during 
CI builds). 
   
   ### Brief change log
   
   This change introduces a static `triggerSnapshotTaskWithRetry` helper 
function which wraps the existing `scheduledExecutorService` instance and 
issues the trigger functions within a retry loop and minor delay to help 
improve reliability. The previous explicit 
`scheduledExecutorService.triggerNonPeriodicScheduledTask()` calls have been 
replaced with this new function in the affected test case.
   
   ### Tests
   
   The `ReplicaTest.testBrokenSnapshotRecovery` was initially updated to use an 
iterative approach (e.g., repeat 50 times) as mentioned in the original issue 
to reproduce the issue. After this was repeatably reproducible, the proposed 
retry-helper was introduced to verify the test would repeatedly pass through 
all of the iterations.
   
   The only change to the test were the previous replacement of the explicit 
`triggerNonPeriodicScheduledTask()` calls with the newly added wrapper.
   
   ### API and Format
   
   N/A
   
   ### Documentation
   
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to