luoyuxia commented on code in PR #1880:
URL: https://github.com/apache/fluss/pull/1880#discussion_r2471609856
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/utils/PaimonConversions.java:
##########
@@ -60,7 +60,10 @@ public class PaimonConversions {
static {
PAIMON_UNSETTABLE_OPTIONS.add(CoreOptions.BUCKET.key());
PAIMON_UNSETTABLE_OPTIONS.add(CoreOptions.BUCKET_KEY.key());
-
PAIMON_UNSETTABLE_OPTIONS.add(CoreOptions.PARTITION_GENERATE_LEGCY_NAME.key());
+ // use literal directly, a future paimon version will rename
+ // the variable PARTITION_GENERATE_LEGCY_NAME to
PARTITION_GENERATE_LEGACY_NAME, use literal
+ // can help avoid NoSuchField error
+ PAIMON_UNSETTABLE_OPTIONS.add("partition.legacy-name");
Review Comment:
I still don't want to modified. Keep `PARTITION_GENERATE_LEGCY_NAME` can
help us find problem quickly(compile will fail) if Paimon remove
`PARTITION_GENERATE_LEGCY_NAME` since we does rely on paimon's behavior of
`PARTITION_GENERATE_LEGCY_NAME`.
Since it's a tempory hacky fix since it's a typo of paimon, after we ungrade
paimon to higer version, we can fall back to use
`PARTITION_GENERATE_LEGACY_NAME ` again, which I believe won't be changed in
paimon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
