Copilot commented on code in PR #1901:
URL: https://github.com/apache/fluss/pull/1901#discussion_r2477225207
##########
fluss-lake/fluss-lake-lance/src/main/java/org/apache/fluss/lake/lance/LanceLakeCatalog.java:
##########
@@ -71,7 +71,7 @@ public void createTable(TablePath tablePath, TableDescriptor
tableDescriptor) {
}
@Override
- public void alterTable(TablePath tablePath, List<TableChange> tableChanges)
+ public void alterTable(TablePath tablePath, List<TableChange>
tableChanges, Context context)
throws TableNotExistException {
Review Comment:
The `context` parameter is added to the method signature but is not used in
the implementation. Consider documenting that the parameter is currently unused
(e.g., with `@SuppressWarnings(\"unused\")` or a comment), or implement its
usage if principal information should be passed to Lance catalog operations.
```suggestion
throws TableNotExistException {
// context parameter is currently unused
```
##########
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java:
##########
@@ -84,7 +84,7 @@ protected Catalog getIcebergCatalog() {
}
@Override
- public void createTable(TablePath tablePath, TableDescriptor
tableDescriptor)
+ public void createTable(TablePath tablePath, TableDescriptor
tableDescriptor, Context context)
Review Comment:
The `context` parameter is added to the method signature but is not used in
the implementation. Consider documenting that the parameter is currently unused
(e.g., with `@SuppressWarnings(\"unused\")` or a comment), or implement its
usage if principal information should be passed to Iceberg catalog operations.
```suggestion
public void createTable(TablePath tablePath, TableDescriptor
tableDescriptor, @SuppressWarnings("unused") Context context)
```
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/PaimonLakeCatalog.java:
##########
@@ -77,7 +77,7 @@ protected Catalog getPaimonCatalog() {
}
@Override
Review Comment:
The `context` parameter is added to the method signature but is not used in
the implementation. Consider documenting that the parameter is currently unused
(e.g., with `@SuppressWarnings(\"unused\")` or a comment), or implement its
usage if principal information should be passed to Paimon catalog operations.
```suggestion
@Override
@SuppressWarnings("unused") // context parameter is currently unused
```
##########
fluss-lake/fluss-lake-lance/src/main/java/org/apache/fluss/lake/lance/LanceLakeCatalog.java:
##########
@@ -43,7 +43,7 @@ public LanceLakeCatalog(Configuration config) {
}
@Override
- public void createTable(TablePath tablePath, TableDescriptor
tableDescriptor) {
+ public void createTable(TablePath tablePath, TableDescriptor
tableDescriptor, Context context) {
Review Comment:
The `context` parameter is added to the method signature but is not used in
the implementation. Consider documenting that the parameter is currently unused
(e.g., with `@SuppressWarnings(\"unused\")` or a comment), or implement its
usage if principal information should be passed to Lance catalog operations.
##########
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java:
##########
@@ -117,7 +117,7 @@ public void createTable(TablePath tablePath,
TableDescriptor tableDescriptor)
}
@Override
- public void alterTable(TablePath tablePath, List<TableChange> tableChanges)
+ public void alterTable(TablePath tablePath, List<TableChange>
tableChanges, Context context)
Review Comment:
The `context` parameter is added to the method signature but is not used in
the implementation. Consider documenting that the parameter is currently unused
(e.g., with `@SuppressWarnings(\"unused\")` or a comment), or implement its
usage if principal information should be passed to Iceberg catalog operations.
```suggestion
public void alterTable(TablePath tablePath, List<TableChange>
tableChanges, @SuppressWarnings("unused") Context context)
```
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/PaimonLakeCatalog.java:
##########
@@ -102,7 +102,7 @@ public void createTable(TablePath tablePath,
TableDescriptor tableDescriptor)
}
@Override
Review Comment:
The `context` parameter is added to the method signature but is not used in
the implementation. Consider documenting that the parameter is currently unused
(e.g., with `@SuppressWarnings(\"unused\")` or a comment), or implement its
usage if principal information should be passed to Paimon catalog operations.
```suggestion
@Override
@SuppressWarnings("unused") // context parameter is currently unused
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
