Copilot commented on code in PR #1909: URL: https://github.com/apache/fluss/pull/1909#discussion_r2479901077
########## website/docs/streaming-lakehouse/integrate-data-lakes/lance.md: ########## @@ -72,6 +72,8 @@ Additionally, when following the [Start Datalake Tiering Service](maintenance/ti > **NOTE**: Fluss v0.8 only supports tiering log tables to Lance. +> **NOTE**: The Lance connector leverages Arrow Java library, which operates on off-heap memory. To prevent `java.lang.OutOfMemoryError: Direct buffer memory` error in Flink Task Manager, please increase the value of `taskmanager.memory.task.off-heap.size` in `<FLINK_HOME>/conf/config.yaml` to an appropriate size. Review Comment: The note mentions increasing the configuration 'to an appropriate size' but doesn't provide guidance on what values to use. Consider adding a specific recommendation or example value (e.g., '512m', '1g') to help users configure this setting properly. ```suggestion > **NOTE**: The Lance connector leverages Arrow Java library, which operates on off-heap memory. To prevent `java.lang.OutOfMemoryError: Direct buffer memory` error in Flink Task Manager, please increase the value of `taskmanager.memory.task.off-heap.size` in `<FLINK_HOME>/conf/config.yaml` to at least `'512m'` (e.g., `taskmanager.memory.task.off-heap.size: 512m`). You may need to adjust this value higher (such as `'1g'`) depending on your workload and data size. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
