MehulBatra commented on PR #2002: URL: https://github.com/apache/fluss/pull/2002#issuecomment-3563471298
> Thanks @MehulBatra for the great work! The new homepage looks really nice! > > I think we can remove the old `background.jpg` now. > > A minor suggestion (not required if difficult to do): when scrolling below the banner image, perhaps we can change the transparent navbar to a regular (opaque) navbar to make the buttons on it clearly visible. > > <img alt="image" width="2000" height="1198" src="https://private-user-images.githubusercontent.com/5378924/517239538-0d472303-6386-42ac-9358-cd2e54164310.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjM3Mzg2NTMsIm5iZiI6MTc2MzczODM1MywicGF0aCI6Ii81Mzc4OTI0LzUxNzIzOTUzOC0wZDQ3MjMwMy02Mzg2LTQyYWMtOTM1OC1jZDJlNTQxNjQzMTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTEyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTExMjFUMTUxOTEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTU2ZmVmN2QxZGIxODIzZmU0ZTE4ZmQ2MWY2Y2Y0ZjkwZjU1NTE3YjFlZWU1YTFjMmU3ODAyMGEyMzhiMjQyNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.AVxOZoxMUKn4q6-4y2DErH8Jqc0fi15gHLmkPhxcjz4";> addressed this by adding the scroll listener logic and updating the styles to handle both transparent and opaque states -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/5378924/517239538-0d472303-6386-42ac-9358-cd2e54164310.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjM3Mzg2NTMsIm5iZiI6MTc2MzczODM1MywicGF0aCI6Ii81Mzc4OTI0LzUxNzIzOTUzOC0wZDQ3MjMwMy02Mzg2LTQyYWMtOTM1OC1jZDJlNTQxNjQzMTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTEyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTExMjFUMTUxOTEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTU2ZmVmN2QxZGIxODIzZmU0ZTE4ZmQ2MWY2Y2Y0ZjkwZjU1NTE3YjFlZWU1YTFjMmU3ODAyMGEyMzhiMjQyNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.AVxOZoxMUKn4q6-4y2DErH8Jqc0fi15gHLmkPhxcjz4"](https://private-user-images.githubusercontent.com/5378924/517239538-0d472303-6386-42ac-9358-cd2e54164310.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjM3Mzg2NTMsIm5iZiI6MTc2MzczODM1MywicGF0aCI6Ii81Mzc4OTI0LzUxNzIzOTUzOC0wZDQ3MjMwMy02Mzg2LTQyYWMtOTM1OC1jZDJlNTQxNjQzMTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTEyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTExMjFUMTUxOTEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTU2ZmVmN2QxZGIxODIzZmU0ZTE4ZmQ2MWY2Y2Y0ZjkwZjU1NTE3YjFlZWU1YTFjMmU3ODAyMGEyMzhiMjQyNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.AVxOZoxMUKn4q6-4y2DErH8Jqc0fi15gHLmkPhxcjz4"){kind=link}