loserwang1024 commented on code in PR #2010:
URL: https://github.com/apache/fluss/pull/2010#discussion_r2562917337
##########
fluss-common/src/main/java/org/apache/fluss/metadata/Schema.java:
##########
@@ -331,19 +411,27 @@ public Schema build() {
*/
@PublicStable
public static final class Column implements Serializable {
+ public static final short UNKNOWN_COLUMN_ID = -1;
private static final long serialVersionUID = 1L;
+ private final short columnId;
private final String columnName;
private final DataType dataType;
private final @Nullable String comment;
public Column(String columnName, DataType dataType) {
- this(columnName, dataType, null);
+ this(columnName, dataType, null, UNKNOWN_COLUMN_ID);
Review Comment:
Yes, I also want to do it. But as a public api, I cannot remove this
constructor ` Column(String columnName, DataType dataType)`. If not set -1, I
have no idea how to handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
