wuchong commented on issue #2041: URL: https://github.com/apache/fluss/issues/2041#issuecomment-3586026735
Thank you @leekeiabstraction , this looks good to me. One more thing we need to take care of is the resource closing, the `ScanRecords` should also be closed if any failure happens, this can be done by closing `ScanReocrds`/`CloseableIterators` in `org.apache.flink.connector.base.source.reader.RecordsWithSplitIds#recycle`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
