swuferhong commented on code in PR #2075:
URL: https://github.com/apache/fluss/pull/2075#discussion_r2579912544
##########
fluss-server/src/main/java/org/apache/fluss/server/replica/ReplicaManager.java:
##########
@@ -1304,14 +1304,27 @@ private void maybeAddDelayedFetchLog(
boolean errorReadingData = false;
boolean hasFetchFromLocal = false;
Map<TableBucket, FetchBucketStatus> fetchBucketStatusMap = new
HashMap<>();
+ Map<TableBucket, FetchLogResultForBucket> expectedErrorBuckets = new
HashMap<>();
for (Map.Entry<TableBucket, LogReadResult> logReadResultEntry :
logReadResults.entrySet()) {
TableBucket tb = logReadResultEntry.getKey();
LogReadResult logReadResult = logReadResultEntry.getValue();
FetchLogResultForBucket fetchLogResultForBucket =
logReadResult.getFetchLogResultForBucket();
if (fetchLogResultForBucket.failed()) {
- errorReadingData = true;
- break;
+ // Check if this is an expected error (like
NOT_LEADER_OR_FOLLOWER,
+ // UNKNOWN_TABLE_OR_BUCKET, LOG_OFFSET_OUT_OF_RANGE) which
should not
Review Comment:
`LOG_OFFSET_OUT_OF_RANGE` include or not? I see that you did not include it
in method `isNonCriticalFetchError(Errors error)` of judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
